fix(cloudformation): handle telemetry setting in upgrade path case where setting is not registered#8343
Merged
laileni-aws merged 8 commits intoaws:masterfrom Nov 21, 2025
Merged
Conversation
added 3 commits
November 20, 2025 18:17
…ere setting is not registered
|
Zee2413
reviewed
Nov 21, 2025
satyakigh
approved these changes
Nov 21, 2025
Zee2413
approved these changes
Nov 21, 2025
kddejong
approved these changes
Nov 21, 2025
Contributor
|
/retryBuilds |
manodnyab
approved these changes
Nov 21, 2025
laileni-aws
approved these changes
Nov 21, 2025
aws-ajangg
pushed a commit
to aws-ajangg/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2026
…ere setting is not registered (aws#8343) ## Problem When the extension is upgraded and user does not do a full restart, it is possible for new cloudformation telemetry setting to not be registered yet, resulting in error trying to save it. ## Solution Skip the save and do it the next time the extension starts. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Akila Tennakoon <tennakoo@amazon.com> Co-authored-by: manodnyab <66754471+manodnyab@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the extension is upgraded and user does not do a full restart, it is possible for new cloudformation telemetry setting to not be registered yet, resulting in error trying to save it.
Solution
Skip the save and do it the next time the extension starts.
feature/xbranches will not be squash-merged at release time.